Concurrency: Remove release_semaphore method

At any point for any request cancellation, the semaphore will be
decremented. This is an issue since an arbitrary request can desync
the semaphore, causing multiple tasks to be processed at once and
break generation.

Remove this from the networking handlers and therefore, remove the
release_semaphore function itself.

Signed-off-by: kingbri <bdashore3@proton.me>

common/concurrency.py

@@ -36,10 +36,6 @@ async def iterate_in_threadpool(generator: Generator) -> AsyncGenerator:
             break
 
 
-def release_semaphore():
-    generate_semaphore.release()
-
-
 async def generate_with_semaphore(generator: Union[AsyncGenerator, Generator]):
     """Generate with a semaphore."""
 

common/networking.py

@@ -8,8 +8,6 @@ from loguru import logger
 from pydantic import BaseModel
 from typing import Optional
 
-from common.concurrency import release_semaphore
-
 
 class TabbyRequestErrorMessage(BaseModel):
     """Common request error type."""
@@ -53,7 +51,6 @@ def handle_request_error(message: str, exc_info: bool = True):
 def handle_request_disconnect(message: str):
     """Wrapper for handling for request disconnection."""
 
-    release_semaphore()
     logger.error(message)