jalr/OpenRGB
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Changing detector type for NVidia Illumination GPUs to resolve #2617

Browse source 
+ Switching the detector registration to allow enabling / disabling.
This commit is contained in:
Chris 2022-07-24 00:55:48 +10:00
parent 148f69b929
commit fa84a587b5
2 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Controllers/NVIDIAIlluminationController/NVIDIAIlluminationControllerDetect.cpp
View file

@ -57,7 +57,7 @@ static const gpu_pci_device device_list[] =
{NVIDIA_VEN, NVIDIA_RTX3090TI_DEV, NVIDIA_VEN, NVIDIA_RTX3090TI_FE_SUB_DEV, NVIDIA_ILLUMINATION_V1, TREATS_RGBW_AS_RGBW, "NVIDIA 3090TI FE" },
};
bool DetectNVIDIAIllumGPUs()
void DetectNVIDIAIllumGPUs(std::vector<RGBController*> &rgb_controllers)
{
static NV_PHYSICAL_GPU_HANDLE gpu_handles[64];
static NV_S32 gpu_count = 0;
@ -98,7 +98,7 @@ bool DetectNVIDIAIllumGPUs()
new_controller = new NVIDIAIlluminationV1Controller(new_nvapi, device_list[dev_idx].treats_rgbw_as_rgb);
new_rgbcontroller = new RGBController_NVIDIAIlluminationV1(new_controller);
new_rgbcontroller->name = device_list[dev_idx].name;
ResourceManager::get()->RegisterRGBController(new_rgbcontroller);
rgb_controllers.push_back(new_rgbcontroller);
}
break;
}
@ -106,7 +106,6 @@ bool DetectNVIDIAIllumGPUs()
}
}
}
return(true);
}
REGISTER_I2C_BUS_DETECTOR(DetectNVIDIAIllumGPUs);
REGISTER_DETECTOR("NVidia NvAPI Illumination", DetectNVIDIAIllumGPUs);

10
Controllers/NVIDIAIlluminationController/RGBController_NVIDIAIllumination.cpp
View file

@ -19,7 +19,7 @@
@comment Tested on various 30 series GPUs and a Founders Edition 2070 Super
If you want to see if your card should also use this controller, download the DLLs from the release of [this](https://gitlab.com/OpenRGBDevelopers/NvAPISpy).
Perform the global replacement technique, which is specified in the README of NvAPI spy. Once this is complete, use an RGB program of your choice and make some basic
Perform the global replacement technique, which is specified in the README of NvAPI spy. Once this is complete, use an RGB program of your choice and make some basic
lighting changes.
Check the C:\NvAPISpy\ folder and see if the logs created are filled with calls like this:
@ -40,7 +40,7 @@
**DATA_SINGLE_COLOR:: Brightness% 44
```
If you see Get/Set Calls above for zone control, please create a [new device issue](https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/new?issuable_template=New%20Device#)
and attach the relevant details to request support for your device (try various modes in each color, especially white and shades around it, since some cards treat RGBW as
and attach the relevant details to request support for your device (try various modes in each color, especially white and shades around it, since some cards treat RGBW as
standard RGB).
\*-------------------------------------------------------------------*/
@ -52,11 +52,11 @@
@save :x:
@direct :white_check_mark:
@effects :x:
@detectors DetectNVIDIAIlluminationGPUControllers
@detectors DetectNVIDIAIllumGPUs
@comment Tested on various 30 series GPUs and a Founders Edition 2070 Super
If you want to see if your card should also use this controller, download the DLLs from the release of [this](https://gitlab.com/OpenRGBDevelopers/NvAPISpy).
Perform the global replacement technique, which is specified in the README of NvAPI spy. Once this is complete, use an RGB program of your choice and make some basic
Perform the global replacement technique, which is specified in the README of NvAPI spy. Once this is complete, use an RGB program of your choice and make some basic
lighting changes.
Check the C:\NvAPISpy\ folder and see if the logs created are filled with calls like this:
@ -77,7 +77,7 @@
**DATA_SINGLE_COLOR:: Brightness% 44
```
If you see Get/Set Calls above for zone control, please create a [new device issue](https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/new?issuable_template=New%20Device#)
and attach the relevant details to request support for your device (try various modes in each color, especially white and shades around it, since some cards treat RGBW as
and attach the relevant details to request support for your device (try various modes in each color, especially white and shades around it, since some cards treat RGBW as
standard RGB).
\*-------------------------------------------------------------------*/