jalr/OpenRGB
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix signedness issue in LogitechG915Controller.cpp

Browse source
This commit is contained in:
Adam Honse 2024-08-02 11:47:58 -05:00
parent 1ef8af75ae
commit f1a85915f9
1 changed files with 29 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

58
Controllers/LogitechController/LogitechG915Controller/LogitechG915Controller.cpp
View file

@ -115,7 +115,7 @@ void LogitechG915Controller::SetMode
void LogitechG915Controller::SendCommit() void LogitechG915Controller::SendCommit()
{ {
char usb_buf[20]; unsigned char usb_buf[20];
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -133,13 +133,13 @@ void LogitechG915Controller::SendCommit()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read_timeout(dev_handle, (unsigned char *)usb_buf, 20, LOGITECH_READ_TIMEOUT); hid_read_timeout(dev_handle, usb_buf, 20, LOGITECH_READ_TIMEOUT);
} }
void LogitechG915Controller::BeginModeSet() void LogitechG915Controller::BeginModeSet()
{ {
char usb_buf[20]; unsigned char usb_buf[20];
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -157,8 +157,8 @@ void LogitechG915Controller::BeginModeSet()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -176,13 +176,13 @@ void LogitechG915Controller::BeginModeSet()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
} }
void LogitechG915Controller::InitializeModeSet() void LogitechG915Controller::InitializeModeSet()
{ {
char usb_buf[20]; unsigned char usb_buf[20];
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -203,13 +203,13 @@ void LogitechG915Controller::InitializeModeSet()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
} }
void LogitechG915Controller::InitializeDirect() void LogitechG915Controller::InitializeDirect()
{ {
char usb_buf[20]; unsigned char usb_buf[20];
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -227,8 +227,8 @@ void LogitechG915Controller::InitializeDirect()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -246,8 +246,8 @@ void LogitechG915Controller::InitializeDirect()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -266,8 +266,8 @@ void LogitechG915Controller::InitializeDirect()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -287,8 +287,8 @@ void LogitechG915Controller::InitializeDirect()
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
} }
void LogitechG915Controller::SendSingleLed void LogitechG915Controller::SendSingleLed
@ -299,7 +299,7 @@ void LogitechG915Controller::SendSingleLed
unsigned char b unsigned char b
) )
{ {
char usb_buf[20]; unsigned char usb_buf[20];
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -323,8 +323,8 @@ void LogitechG915Controller::SendSingleLed
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
} }
void LogitechG915Controller::SendDirectFrame void LogitechG915Controller::SendDirectFrame
@ -333,7 +333,7 @@ void LogitechG915Controller::SendDirectFrame
unsigned char * frame_data unsigned char * frame_data
) )
{ {
char usb_buf[20]; unsigned char usb_buf[20];
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -356,8 +356,8 @@ void LogitechG915Controller::SendDirectFrame
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read_timeout(dev_handle, (unsigned char *)usb_buf, 20, LOGITECH_READ_TIMEOUT); hid_read_timeout(dev_handle, usb_buf, 20, LOGITECH_READ_TIMEOUT);
} }
void LogitechG915Controller::SendMode void LogitechG915Controller::SendMode
@ -371,7 +371,7 @@ void LogitechG915Controller::SendMode
unsigned char blue unsigned char blue
) )
{ {
char usb_buf[20]; unsigned char usb_buf[20];
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Zero out buffer | | Zero out buffer |
@ -434,6 +434,6 @@ void LogitechG915Controller::SendMode
/*-----------------------------------------------------*\ /*-----------------------------------------------------*\
| Send packet | | Send packet |
\*-----------------------------------------------------*/ \*-----------------------------------------------------*/
hid_write(dev_handle, (unsigned char *)usb_buf, 20); hid_write(dev_handle, usb_buf, 20);
hid_read(dev_handle, (unsigned char *)usb_buf, 20); hid_read(dev_handle, usb_buf, 20);
} }