From f1a85915f9ca8cc691e890ff22126bf9711804f5 Mon Sep 17 00:00:00 2001 From: Adam Honse Date: Fri, 2 Aug 2024 11:47:58 -0500 Subject: [PATCH] Fix signedness issue in LogitechG915Controller.cpp --- .../LogitechG915Controller.cpp | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Controllers/LogitechController/LogitechG915Controller/LogitechG915Controller.cpp b/Controllers/LogitechController/LogitechG915Controller/LogitechG915Controller.cpp index a014923c..1691de63 100644 --- a/Controllers/LogitechController/LogitechG915Controller/LogitechG915Controller.cpp +++ b/Controllers/LogitechController/LogitechG915Controller/LogitechG915Controller.cpp @@ -115,7 +115,7 @@ void LogitechG915Controller::SetMode void LogitechG915Controller::SendCommit() { - char usb_buf[20]; + unsigned char usb_buf[20]; /*-----------------------------------------------------*\ | Zero out buffer | @@ -133,13 +133,13 @@ void LogitechG915Controller::SendCommit() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read_timeout(dev_handle, (unsigned char *)usb_buf, 20, LOGITECH_READ_TIMEOUT); + hid_write(dev_handle, usb_buf, 20); + hid_read_timeout(dev_handle, usb_buf, 20, LOGITECH_READ_TIMEOUT); } void LogitechG915Controller::BeginModeSet() { - char usb_buf[20]; + unsigned char usb_buf[20]; /*-----------------------------------------------------*\ | Zero out buffer | @@ -157,8 +157,8 @@ void LogitechG915Controller::BeginModeSet() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); /*-----------------------------------------------------*\ | Zero out buffer | @@ -176,13 +176,13 @@ void LogitechG915Controller::BeginModeSet() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); } void LogitechG915Controller::InitializeModeSet() { - char usb_buf[20]; + unsigned char usb_buf[20]; /*-----------------------------------------------------*\ | Zero out buffer | @@ -203,13 +203,13 @@ void LogitechG915Controller::InitializeModeSet() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); } void LogitechG915Controller::InitializeDirect() { - char usb_buf[20]; + unsigned char usb_buf[20]; /*-----------------------------------------------------*\ | Zero out buffer | @@ -227,8 +227,8 @@ void LogitechG915Controller::InitializeDirect() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); /*-----------------------------------------------------*\ | Zero out buffer | @@ -246,8 +246,8 @@ void LogitechG915Controller::InitializeDirect() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); /*-----------------------------------------------------*\ | Zero out buffer | @@ -266,8 +266,8 @@ void LogitechG915Controller::InitializeDirect() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); /*-----------------------------------------------------*\ | Zero out buffer | @@ -287,8 +287,8 @@ void LogitechG915Controller::InitializeDirect() /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); } void LogitechG915Controller::SendSingleLed @@ -299,7 +299,7 @@ void LogitechG915Controller::SendSingleLed unsigned char b ) { - char usb_buf[20]; + unsigned char usb_buf[20]; /*-----------------------------------------------------*\ | Zero out buffer | @@ -323,8 +323,8 @@ void LogitechG915Controller::SendSingleLed /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); } void LogitechG915Controller::SendDirectFrame @@ -333,7 +333,7 @@ void LogitechG915Controller::SendDirectFrame unsigned char * frame_data ) { - char usb_buf[20]; + unsigned char usb_buf[20]; /*-----------------------------------------------------*\ | Zero out buffer | @@ -356,8 +356,8 @@ void LogitechG915Controller::SendDirectFrame /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read_timeout(dev_handle, (unsigned char *)usb_buf, 20, LOGITECH_READ_TIMEOUT); + hid_write(dev_handle, usb_buf, 20); + hid_read_timeout(dev_handle, usb_buf, 20, LOGITECH_READ_TIMEOUT); } void LogitechG915Controller::SendMode @@ -371,7 +371,7 @@ void LogitechG915Controller::SendMode unsigned char blue ) { - char usb_buf[20]; + unsigned char usb_buf[20]; /*-----------------------------------------------------*\ | Zero out buffer | @@ -434,6 +434,6 @@ void LogitechG915Controller::SendMode /*-----------------------------------------------------*\ | Send packet | \*-----------------------------------------------------*/ - hid_write(dev_handle, (unsigned char *)usb_buf, 20); - hid_read(dev_handle, (unsigned char *)usb_buf, 20); + hid_write(dev_handle, usb_buf, 20); + hid_read(dev_handle, usb_buf, 20); }