From eecdd4befca78f73cbc80d51e15f69bee91524cc Mon Sep 17 00:00:00 2001
From: Adam Honse <calcprogrammer1@gmail.com>
Date: Wed, 2 Jul 2025 00:22:52 -0500
Subject: [PATCH] Fix warnings in AMBXController.cpp

---
 Controllers/AMBXController/AMBXController.cpp | 64 +++++++++----------
 1 file changed, 32 insertions(+), 32 deletions(-)

diff --git a/Controllers/AMBXController/AMBXController.cpp b/Controllers/AMBXController/AMBXController.cpp
index f1de5bae..cee18d59 100644
--- a/Controllers/AMBXController/AMBXController.cpp
+++ b/Controllers/AMBXController/AMBXController.cpp
@@ -19,43 +19,43 @@ AMBXController::AMBXController(const char* path)
     initialized      = false;
     usb_context      = nullptr;
     dev_handle       = nullptr;
-    
+
     location = "USB: ";
     location += path;
-    
+
     // Initialize libusb in this instance
     if(libusb_init(&usb_context) < 0)
     {
         return;
     }
-    
+
     // Get the device list
     libusb_device** device_list;
     ssize_t device_count = libusb_get_device_list(usb_context, &device_list);
-    
+
     if(device_count < 0)
     {
         return;
     }
-    
+
     for(ssize_t i = 0; i < device_count; i++)
     {
         libusb_device* device = device_list[i];
         struct libusb_device_descriptor desc;
-        
+
         if(libusb_get_device_descriptor(device, &desc) != LIBUSB_SUCCESS)
         {
             continue;
         }
-        
+
         if(desc.idVendor == AMBX_VID && desc.idProduct == AMBX_PID)
         {
             uint8_t bus = libusb_get_bus_number(device);
             uint8_t address = libusb_get_device_address(device);
-            
+
             char current_path[32];
             snprintf(current_path, sizeof(current_path), "%d-%d", bus, address);
-            
+
             if(strcmp(path, current_path) == 0)
             {
                 // Try to open this device
@@ -63,16 +63,16 @@ AMBXController::AMBXController(const char* path)
                 {
                     continue;
                 }
-                
+
                 // Try to detach the kernel driver if attached
                 if(libusb_kernel_driver_active(dev_handle, 0))
                 {
                     libusb_detach_kernel_driver(dev_handle, 0);
                 }
-                
+
                 // Set auto-detach for Windows compatibility
                 libusb_set_auto_detach_kernel_driver(dev_handle, 1);
-                
+
                 // Claim the interface
                 if(libusb_claim_interface(dev_handle, 0) != LIBUSB_SUCCESS)
                 {
@@ -80,26 +80,26 @@ AMBXController::AMBXController(const char* path)
                     dev_handle = nullptr;
                     continue;
                 }
-                
+
                 // Get string descriptor for serial number if available
                 if(desc.iSerialNumber != 0)
                 {
                     unsigned char serial_str[256];
-                    int serial_result = libusb_get_string_descriptor_ascii(dev_handle, desc.iSerialNumber, 
+                    int serial_result = libusb_get_string_descriptor_ascii(dev_handle, desc.iSerialNumber,
                                                                          serial_str, sizeof(serial_str));
                     if(serial_result > 0)
                     {
                         serial = std::string(reinterpret_cast<char*>(serial_str), serial_result);
                     }
                 }
-                
+
                 // Successfully opened and claimed the device
                 initialized = true;
                 break;
             }
         }
     }
-    
+
     libusb_free_device_list(device_list, 1);
 }
 
@@ -108,29 +108,29 @@ AMBXController::~AMBXController()
     if(initialized)
     {
         // Turn off all lights before closing
-        unsigned int led_ids[5] = 
-        { 
+        unsigned int led_ids[5] =
+        {
             AMBX_LIGHT_LEFT,
             AMBX_LIGHT_RIGHT,
             AMBX_LIGHT_WALL_LEFT,
             AMBX_LIGHT_WALL_CENTER,
             AMBX_LIGHT_WALL_RIGHT
         };
-        
+
         RGBColor colors[5] = { 0, 0, 0, 0, 0 };
         SetLEDColors(led_ids, colors, 5);
     }
-    
+
     if(dev_handle != nullptr)
     {
         // Release the interface
         libusb_release_interface(dev_handle, 0);
-        
+
         // Close the device
         libusb_close(dev_handle);
         dev_handle = nullptr;
     }
-    
+
     if(usb_context != nullptr)
     {
         libusb_exit(usb_context);
@@ -159,7 +159,7 @@ void AMBXController::SendPacket(unsigned char* packet, unsigned int size)
     {
         return;
     }
-    
+
     int actual_length = 0;
     libusb_interrupt_transfer(dev_handle, AMBX_ENDPOINT_OUT, packet, size, &actual_length, 100);
 }
@@ -170,19 +170,19 @@ void AMBXController::SetLEDColor(unsigned int led, RGBColor color)
     {
         return;
     }
-    
-    unsigned char color_buf[6] = 
-    { 
-        AMBX_PACKET_HEADER, 
-        static_cast<unsigned char>(led), 
+
+    unsigned char color_buf[6] =
+    {
+        AMBX_PACKET_HEADER,
+        static_cast<unsigned char>(led),
         AMBX_SET_COLOR,
-        RGBGetRValue(color),
-        RGBGetGValue(color),
-        RGBGetBValue(color)
+        (unsigned char)RGBGetRValue(color),
+        (unsigned char)RGBGetGValue(color),
+        (unsigned char)RGBGetBValue(color)
     };
 
     SendPacket(color_buf, 6);
-    
+
     std::this_thread::sleep_for(std::chrono::milliseconds(2));
 }