jalr/OpenRGB
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add error logs for non logged exceptions

Browse source
This commit is contained in:
morg 2022-02-28 20:59:47 +01:00 • committed by Adam Honse
parent ddeb5de65e
commit d8f28b546d
5 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Controllers/AsusAuraUSBController/AsusAuraUSBControllerDetect.cpp
View file

@ -130,9 +130,10 @@ void DetectAsusAuraUSBMotherboards(hid_device_info* info, const std::string& /*n
rgb_controller->name = "ASUS " + dmi.getMainboard();
ResourceManager::get()->RegisterRGBController(rgb_controller);
}
catch(std::runtime_error&)
catch(const std::runtime_error& ex)
{
// reading the config table failed
LOG_ERROR("[AsusAuraUSB] An error occured while reading the config table: %s", ex.what());
}
}
}

7
Controllers/PhilipsHueController/PhilipsHueController.cpp
View file

@ -5,6 +5,7 @@
\*---------------------------------------------------------*/
#include "PhilipsHueController.h"
#include "LogManager.h"
PhilipsHueController::PhilipsHueController(hueplusplus::Light light_ptr, std::string bridge_ip):light(light_ptr)
{
@ -57,9 +58,9 @@ void PhilipsHueController::SetColor(unsigned char red, unsigned char green, unsi
{
light.setColorRGB(rgb, 0);
}
catch(std::exception& e)
catch(const std::exception& e)
{
LOG_ERROR("[PhilipsHueController] An error occured while setting the colors: %s", e.what());
}
}
@ -75,7 +76,7 @@ void PhilipsHueController::SetColor(unsigned char red, unsigned char green, unsi
}
catch(std::exception& e)
{
LOG_ERROR("[PhilipsHueController] An error occured while setting the colors: %s", e.what());
}
}
}

4
Controllers/PhilipsHueController/PhilipsHueControllerDetect.cpp
View file

@ -222,9 +222,9 @@ void DetectPhilipsHueControllers(std::vector<RGBController*>& rgb_controllers)
}
}
}
catch(std::exception &e)
catch(const std::exception &e)
{
LOG_INFO("Exception occurred in Philips Hue detection");
LOG_INFO("Exception occurred in Philips Hue detection: %s", e.what());
}
}
} /* DetectPhilipsHueControllers() */

5
SettingsManager.cpp
View file

@ -10,6 +10,7 @@
\*-----------------------------------------*/
#include "SettingsManager.h"
#include "LogManager.h"
#include <fstream>
#include <iostream>
@ -82,6 +83,8 @@ void SettingsManager::LoadSettings(std::string filename)
| parsing failed. Clear out any data in the store |
| as it is corrupt. |
\*-------------------------------------------------*/
LOG_ERROR("[SettingsManager] JSON parsing failed: %s", e.what());
settings_data.clear();
}
}
@ -101,7 +104,7 @@ void SettingsManager::SaveSettings()
}
catch(const std::exception& e)
{
LOG_ERROR("[SettingsManager] Cannot write to file: %s", e.what());
}
settings_file.close();

5
qt/OpenRGBPluginsPage/OpenRGBPluginsPage.cpp
View file

@ -4,6 +4,7 @@
#include <QGraphicsScene>
#include "filesystem.h"
#include "LogManager.h"
#include "OpenRGBPluginsPage.h"
#include "ui_OpenRGBPluginsPage.h"
@ -144,9 +145,9 @@ bool Ui::OpenRGBPluginsPage::InstallPlugin(std::string install_file)
return true;
}
catch(std::exception& e)
catch(const std::exception& e)
{
LOG_ERROR("[PluginsManager] Failed to install plugin: %s", e.what());
}
return false;