jalr/OpenRGB
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove convertQPath functions as it's only used once, fixes a warning for the unused version

Browse source
This commit is contained in:
Adam Honse 2023-05-01 19:59:12 -05:00
parent 86f048fc72
commit 79e80021b1
1 changed files with 1 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

14
PluginManager.cpp
View file

@ -3,18 +3,6 @@
#include "PluginManager.h" #include "PluginManager.h"
#include "OpenRGBThemeManager.h" #include "OpenRGBThemeManager.h"
// These two functions address the lack of a type-aware way to construct a QString
// Allows to avoid double conversions
static QString convertQPath(const std::string & filepath)
{
return QString::fromStdString(filepath);
}
static QString convertQPath(const std::wstring & filepath)
{
return QString::fromStdWString(filepath);
}
PluginManager::PluginManager() PluginManager::PluginManager()
{ {
/*---------------------------------------------------------*\ /*---------------------------------------------------------*\
@ -117,7 +105,7 @@ void PluginManager::AddPlugin(const filesystem::path& path)
| Create a QPluginLoader and load the plugin | | Create a QPluginLoader and load the plugin |
\*-----------------------------------------------------------------*/ \*-----------------------------------------------------------------*/
std::string path_string = path.generic_u8string(); std::string path_string = path.generic_u8string();
QPluginLoader* loader = new QPluginLoader(convertQPath(path_string)); QPluginLoader* loader = new QPluginLoader(QString::fromStdString(path_string));
QObject* instance = loader->instance(); QObject* instance = loader->instance();
/*-----------------------------------------------------------------*\ /*-----------------------------------------------------------------*\