jalr/OpenRGB
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix unbounded array access in Aura RAM detection that caused segfaults on certain systems

Browse source
This commit is contained in:
Adam Honse 2019-12-31 18:37:09 -06:00
parent 189bf0d7a4
commit 5f3fe509a4
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Controllers/AuraController/AuraControllerDetect.cpp
View file

@ -113,14 +113,19 @@ void DetectAuraControllers(std::vector<i2c_smbus_interface*> &busses, std::vecto
AuraController temp_controller(busses[bus], 0x77);
// Search through available addresses and skip over ones that are already in use
res = busses[bus]->i2c_smbus_write_quick(aura_ram_addresses[address_list_idx], I2C_SMBUS_WRITE);
while (res >= 0)
do
{
address_list_idx++;
res = busses[bus]->i2c_smbus_write_quick(aura_ram_addresses[address_list_idx], I2C_SMBUS_WRITE);
}
if(address_list_idx < AURA_RAM_ADDRESS_COUNT)
{
res = busses[bus]->i2c_smbus_write_quick(aura_ram_addresses[address_list_idx], I2C_SMBUS_WRITE);
}
else
{
break;
}
} while (res >= 0);
temp_controller.AuraRegisterWrite(AURA_REG_SLOT_INDEX, slot);
temp_controller.AuraRegisterWrite(AURA_REG_I2C_ADDRESS, (aura_ram_addresses[address_list_idx] << 1));