jalr/OpenRGB
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't unload/remove plugins immediately, instead require a restart to prevent unclean unload/crash

Browse source
This commit is contained in:
Adam Honse 2024-05-16 21:38:01 -05:00
parent 6f55f0e0c0
commit 17ad77f07a
2 changed files with 39 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
qt/OpenRGBPluginsPage/OpenRGBPluginsPage.cpp
View file

@ -235,12 +235,17 @@ void Ui::OpenRGBPluginsPage::on_RemovePluginButton_clicked()
if((plugin_settings["plugins"][plugin_idx]["name"] == entries[cur_row]->ui->NameValue->text().toStdString())
&&(plugin_settings["plugins"][plugin_idx]["description"] == entries[cur_row]->ui->DescriptionValue->text().toStdString()))
{
plugin_settings["plugins"].erase(plugin_idx);
/*-----------------------------------------------------*\
| Mark plugin to be removed on next restart |
\*-----------------------------------------------------*/
plugin_settings["plugins_remove"][plugin_settings["plugins_remove"].size()] = entries[cur_row]->ui->PathValue->text().toStdString();
ResourceManager::get()->GetSettingsManager()->SetSettings("Plugins", plugin_settings);
ResourceManager::get()->GetSettingsManager()->SaveSettings();
break;
QMessageBox::information(this, tr("Restart Needed"), tr("The plugin will be fully removed after restarting OpenRGB."), QMessageBox::Ok);
return;
}
}
}