Refactor Makefile #23

New issue

Open

opened 2020-08-14 11:57:24 +00:00 by sbruder · 5 comments

sbruder commented

2020-08-14 11:57:24 +00:00

(Migrated from gitlab.jalr.de)

The Makefile has many hardcoded parts (IP addresses, names (“debian-buster”) etc.) and in general is very complex.

Local testing is responsible for a large part of the complexity of the Makefile, yet it is not often used. Additionally, I don’t think local testing currently works (since the created torrent does not have any seeders nor a webseed url). This seems to have been introduced in e43f34991d.
Is local testing a feature we want to keep or is the complexity not worth maintaining it @jalr?

Also, the Makefile reimplements parts of tftpgen, which is somewhat redundant.

For me the complexity made me ignore the Makefile which lead to variables that are not used anymore in the docker build process still being passed.

TODO:

Do we want to keep local testing?
Replace hardcoded parts with variables
- IP addresses (for local testing)
- “debian-buster”
Remove unused variables
- ANNOUNCE (done in !64)
- WEBSEED (in the case of removing local testing)
- ANSIBLE_VERSION, PACKER_VERSION (became useless in !63, possibly replace with pinning the alpine version)

The Makefile has many hardcoded parts (IP addresses, names (“debian-buster”) etc.) and in general is very complex. Local testing is responsible for a large part of the complexity of the Makefile, yet it is not often used. Additionally, I don’t think local testing currently works (since the created torrent does not have any seeders nor a webseed url). This seems to have been introduced in e43f34991d2bf8e1038fa7c5d9352e1a01563c80. Is local testing a feature we want to keep or is the complexity not worth maintaining it @jalr? Also, the Makefile reimplements parts of tftpgen, which is somewhat redundant. For me the complexity made me ignore the Makefile which lead to variables that are not used anymore in the docker build process still being passed. TODO: - [ ] Do we want to keep local testing? - [ ] Replace hardcoded parts with variables - [ ] IP addresses (for local testing) - [ ] “debian-buster” - [ ] Remove unused variables - [X] `ANNOUNCE` (done in !64) - [ ] `WEBSEED` (in the case of removing local testing) - [ ] `ANSIBLE_VERSION`, `PACKER_VERSION` (became useless in !63, possibly replace with pinning the alpine version)

sbruder commented

2020-08-14 12:05:21 +00:00

(Migrated from gitlab.jalr.de)

changed title from {-Local testing-} to {+Refactor Makefile+}

changed title from **{-Local testing-}** to **{+Refactor Makefile+}**

sbruder commented

2020-08-14 12:05:21 +00:00

(Migrated from gitlab.jalr.de)

changed the description

sbruder commented

2020-08-14 12:09:20 +00:00

(Migrated from gitlab.jalr.de)